Re: svn commit: rev 5119 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs tests/clients/cmdline/svntest libsvn_repos

Glenn A. Thompson wrote:

> Hey,
> Forgive me for being blunt, but I don't like this config solution at all.
> We are going to add a config option for every little thing for every
> fs type? .... Bah!

Perhaps, perhaps not. For "svnadmin create", we'll probably have both:
an option for every little thing, and an option to read other options
from a config file. There's nothing wrong with being flexible.

> My solution, which I'm in the process of getting back up-to-date, is
> more flexible.
> I use the svn_config_t structure which is loaded by svnadmin using
> svn_config_read.

Where do you read the config file(s) from, if there's no FS or
repository yet?

> It gets passed opaquely from avnadmin all the way to the fs
> initializer in a FS implementation.
> Only the administrator and the affected code portions need to know
> about specific options.
> I also have extensions (as part of the first SQL solution) to the
> svn_config_t methods. My SQL statement support code makes extensive
> use of config files.
>
> Please consider a different route:-(

Well, if you had your patch on a branch, I could've looked there. .-)
I tried to come up with an interface that's independent of the FS
back-end. I think I succeeded in that. Once your FS abstraction layer is
in, we can think about a better solution.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org