[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [ PATCH ] Docs chapter 3

From: B. W. Fitzpatrick <fitz_at_red-bean.com>
Date: 2003-02-23 08:23:43 CET

pll@lanminds.com writes:

> And here's chapter 3. A little more going on in this one. As I
> explained to Ben via private e-mail, I did 4 basic things:
>
> 1. In chps 2/3 I replaced all occurences of 'A svn...'
> with 'An svn...' since it seems to flow a little easier
> when reading it.
>
> 2. Changed a couple paragraphs to read a little better.
> This includes adding a couple of itemized lists where I
> think the infomation is better presented that way than
> being buried in a paragraph form.
>
> 3. Fixed the occasional typo
>
> 4. Added a bunch of comment blocks explaining:
> - why I did what I did
> - why I don't like something
> - what more is needed to clarify something
> - and occasionally, how I think you could fix things :)
>
> Also, as mentioned to Ben, I can either provide my feedback in patch
> format, or qualitatively describe things, but that will take a little
> longer. Feel free to tell me what you want me to tell you :)

Applied, with modifications, in 5033.

Paul, a few things to note:

- Patch format is fine.
- Please supply a log message in the future.
- The comments were *great*.
- Make sure you validate your xml before submitting--there were a
  bunch of validation errors in your patch.
- Never use an itemizedlist when you need a variablelist. :)
- No TABs please.

Thanks again,

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 23 08:25:10 2003

This is an archived mail posted to the Subversion Dev mailing list.