Re: svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

cmpilato@collab.net wrote:

>=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:
>
>
>
>>Michael Price wrote:
>>
>>
>>
>>>Branko $,1 ,(Bibej writes:
>>>
>>>
>>>>Running all tests in commit_tests.py...FAILURE
>>>>
>>>>[snip]
>>>>
>>>>At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
>>>>FAIL: commit_tests.py 16: commit files and dirs with URI-unsafe characters
>>>>
>>>>
>>>I'm testing ra_local on linux and solaris at the moment. Linux passed
>>>this test. Solaris is still compiling.
>>>
>>>
>>>
>>>>FAIL: win-tests.py
>>>>
>>>>
>>>Alas, I have no Windows-foo.
>>>
>>>
>>>
>>>
>>I think Windows simply doesn't allow files with control chars (tabs, in
>>this case) in the names. We may have to extract this subtest into its
>>own test and skip it on Windows.
>>
>>
>
>Nono. Don't skip the whole test -- just specialize tab_path with the
>other couple of ugly paths.
>
What I meant was have a separate test for the tab thing -- but you're
right, special-casing is better here. Youre patch looks fine, go ahead
and commit it. I don't thing it has to go on the branch, though.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org