[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

From: <cmpilato_at_collab.net>
Date: 2003-02-19 22:24:43 CET

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> Michael Price wrote:
>
> >Branko $,1 ,(Bibej writes:
> > > Running all tests in commit_tests.py...FAILURE
> > >
> > > [snip]
> > >
> > > At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
> > > FAIL: commit_tests.py 16: commit files and dirs with URI-unsafe characters
> >
> >I'm testing ra_local on linux and solaris at the moment. Linux passed
> >this test. Solaris is still compiling.
> >
> > > FAIL: win-tests.py
> >
> >Alas, I have no Windows-foo.
> >
> >
>
> I think Windows simply doesn't allow files with control chars (tabs, in
> this case) in the names. We may have to extract this subtest into its
> own test and skip it on Windows.

Nono. Don't skip the whole test -- just specialize tab_path with the
other couple of ugly paths.

Index: commit_tests.py
===================================================================
--- commit_tests.py (revision 4957)
+++ commit_tests.py (working copy)
@@ -1040,15 +1040,17 @@
   if svntest.main.windows:
     angle_name = '$angle$'
     nasty_name = '#![]{}()$$%'
+ tab_name = 'tab-name'
   else:
     angle_name = '<angle>'
     nasty_name = '#![]{}()<>%'
-
+ tab_name = "tab\tname"
+
   # Make some convenient paths.
   hash_dir = os.path.join(wc_dir, '#hash#')
   nasty_dir = os.path.join(wc_dir, nasty_name)
   space_path = os.path.join(wc_dir, 'A', 'D', 'space path')
- tab_path = os.path.join(wc_dir, 'A', 'D', 'G', "tab\tpath")
+ tab_path = os.path.join(wc_dir, 'A', 'D', 'G', tab_name)
   bang_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bang!')
   bracket_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bra[ket')
   brace_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bra{e')

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 19 22:26:25 2003

This is an archived mail posted to the Subversion Dev mailing list.