[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [BIKESHED] "anonymous" username usage in mod_dav_svn.

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-02-19 07:14:54 CET

On Tue, Feb 18, 2003 at 03:49:33PM -0600, cmpilato@collab.net wrote:
> I would like to change mod_dav_svn's dav_svn_get_resource() to stop
> manufacturing a username of "anonymous" when no authenticated username
> exists, and to use the empty string instead. My reasons:
>
> - Subversion is perfectly happy not having an svn:author property
> on each revision.
> - ra_local and ra_svn do not manufacture such names (and never have).
> - 'svnadmin create' does not manufacture this name.
> - The absence of a username stands out more strongly in an 'svn st
> -v' or 'svn ls -v' listing than just another string.
> - It unnecessary swallows a commonly used word that *could* actually
> be used as a real username.
>
> Any objections?

-0 (I think the current behavior makes sense)

Omit the property entirely, rather than storing the empty string into the
property.

Also note that the log message stuff plays a little fast and loose with
translating here and there between NULL values and empty strings and missing
properties. (the last I looked, at least; kind of a mess; the log receiver
API should be tightened up to allow NULL values to propagate thru; only at
the point where we print do we need to be concerned with "what do I do when
I see a NULL?")

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 19 07:10:49 2003

This is an archived mail posted to the Subversion Dev mailing list.