[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-11 19:11:55 CET

kfogel@tigris.org wrote:

>Author: kfogel
>Date: 2003-02-10 18:00:30 -0600 (Mon, 10 Feb 2003)
>New Revision: 4824
>
>Added:
> trunk/subversion/libsvn_subr/cmdline.c
>Removed:
> trunk/subversion/clients/init_cmdline.h
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/include/svn_pools.h
> trunk/subversion/svnadmin/main.c
> trunk/subversion/svnlook/main.c
> trunk/subversion/svnserve/main.c
> trunk/subversion/svnversion/main.c
> trunk/subversion/tests/libsvn_subr/target-test.c
>Log:
>Replace an unfamiliar mess with a familiar one:
>
>* subversion/clients/init_cmdline.h: Removed.
>
>* subversion/libsvn_subr/cmdline.c: New file.
>
>* subversion/include/svn_pools.h
> (svn_cmdline_init): New prototype, here for lack of a better place.
> See also comment about possible move to APR.
>
>

As you might have guessed, given the last paragraph above, I don't agree
with putting this into libsvn_subr. It doesn't belong there. We need a
separate library that contains only utilities for our command-line
clients. There are other things that should go there; for instance,
svn_path_internal_style and svn_path_local_style don't belong in
libsvn_subr, nor does opt.c. I also strongly suspect that the
command-line client support library should _only_ exist as a static lib,
not a shared one. I'd suggest refactoring all this into a new directory
under subversion/clients.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 11 19:12:49 2003

This is an archived mail posted to the Subversion Dev mailing list.