[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4775 - in branches/issue-1037-uuids/subversion: include libsvn_repos

From: mark benedetto king <mbk_at_boredom.org>
Date: 2003-02-11 00:10:45 CET

On Mon, Feb 10, 2003 at 11:59:22AM -0600, Karl Fogel wrote:
> cmpilato@collab.net writes:
> > Our dumper and loader are *generally* written so that unrecognized
> > headers are ignored. That said, our loader does not ignore whole
> > header *blocks*, so I'm cool with your version increment. As you
> > stated, we'll just have a format that is:
> >
> > version-number
> >
> > repos-headers
> >
> > revision-headers
> > ...
>
> The question is whether old loaders will choke if they see the new
> UUID header -- and they do, right?
>

Yes, they should, because it's an unknown record type, which is why the
incremented version number was necessary. I don't have an old loader
around to test, though. If I change "UUID" to "UUIE", the new loader
chokes.

> However, our policy about ignoring unrecognized headers is official,
> as I recall. So now that we have a repos-headers block, as well as
> revision headers blocks, we can add new repos headers with impunity --
> assuming the *current* code knows to ignore unknown headers. (Does
> it?)

It is my impression that it reads each block into a hash, and then
processes the hash. This should make it ignore unknown headers.
If I add a "Foo: bar." header after the "UUID" header, it seems
to be ignored.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 11 00:11:40 2003

This is an archived mail posted to the Subversion Dev mailing list.