[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4803 - in trunk/subversion: include libsvn_subr libsvn_ra_local libsvn_client clients/cmdline libsvn_ra_svn libsvn_ra_dav

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-10 22:35:54 CET

Karl Fogel wrote:

>rooneg@tigris.org writes:
>>--- trunk/subversion/include/svn_client.h (original)
>>+++ trunk/subversion/include/svn_client.h Sat Feb 8 18:59:26 2003
>>@@ -269,6 +269,12 @@
>> /** log message callback baton */
>> void *log_msg_baton;
>>+ /** a hash mapping of <tt>const char *</> configuration file names to
>>+ * @c svn_config_t *'s. for example, the '~/.subversion/config' file's
>>+ * contents should have the key "config".
>>+ */
>>+ apr_hash_t *config;
>> } svn_client_ctx_t;
>Is "</>" valid doxygen, or just a typo?

oh, that's definately a typo ;-)

>The change looks great, btw. It's so big that I can't say whether my
>review would definitely have spotted any other errors, but the overall
>shape seems right to me at least. Thanks for taking on this beast :-).

no problem, it was fun ;-)

i'll probably start pushing the config options down further into the
code today. i'm not going to bother sending it into libsvn_wc for the
diff3 command line option stuff, since i'm hoping and praying that will
go away soon in favor of sander's diff lib, and it's a pain to get the
hash down that far anyway. the stuff in libsvn_subr shouldn't be that
hard though, so i'll likely attack there next.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 10 22:37:09 2003

This is an archived mail posted to the Subversion Dev mailing list.