[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash in svn_client_commit()

From: SteveKing <steveking_at_gmx.ch>
Date: 2003-02-10 21:42:54 CET

> "SteveKing" <steveking@gmx.ch> writes:
> > when calling the function svn_client_commit() with
> > the second parameter being an empty apr_array_header_t
> > (created with apr_array_make() and nothing added to it)
> > then subversion crashes.
> > Sure clients using this function should check if they're
> > passing an empty array or not but it's 'rude' of subversion
> > to crash instead of throwing an error.
> > I used revision 4753.
>
> How did you make this happen? By running 'svn', or by writing new
> code that uses the API?
by writing a new client (TortoiseSVN). I had a function which first
does something like svn st <folder> to get all the files which need
to get commited, then show all those files in a dialog box where
the user can select/deselect single files for the commit (sometimes
it's usefull to split changes into several commits or to simply not
commit some those changes which don't work right now). If the
user deselects all the files (or if no file needs a commit) then my
client crashed 'cause the second parameter to svn_client_commit()
was an empty array.
I fixed it now by checking first before calling svn_client_commit()
though it has no priority to get 'fixed' in subversion.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 10 21:43:59 2003

This is an archived mail posted to the Subversion Dev mailing list.