Re: svn commit: rev 4743 - in trunk/subversion: libsvn_ra_svn svnserve

epg@tigris.org writes:
> Log:
> Hook ra_svn up with checksumming action.

Whoo-hoo!

> + apr_md5_final(digest, &md5_context);
> + hex_digest = svn_md5_digest_to_cstring(digest, pool);
> + if (strcmp (hex_digest, expected_checksum) != 0)
> + return svn_error_createf
> + (SVN_ERR_CHECKSUM_MISMATCH, NULL,
> + "ra_svn_get_file: checksum mismatch for '%s':\n"
> + " expected checksum: %s\n"
> + " actual checksum: %s\n",
> + path, expected_checksum, hex_digest);
> +
> SVN_ERR(svn_stream_close(stream));
> return SVN_NO_ERROR;
> }

Since there's no check for whether an expected_checksum came over the
wire, does that mean this change isn't compatible with older
`svnserve's? (Presumably either expected_checksum would be NULL, in
which case I guess the strcmp would be protected, or the empty string,
which still wouldn't match).

Just speaking off the top of my head, here; please send me packin' if
I'm missing something obvious. :)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 5 08:30:58 2003