[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "serve.c" and "text_deltas" parameter of svn_repos_begin_report

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2003-02-05 03:15:27 CET

Julian Foad wrote:
> Michael Wood wrote:
>> Your patch is wrapped.
>
> Very interesting: you saw a wrapped copy, and the mailing list
> archive shows it wrapped, but the copy I got back from the list
> server is not wrapped for me. I think it's because your (and the
> archive's) viewers don't support "format=flowed" in the
> "Content-Type" header field.

No, actually the "problem" is at your end. You do have the
format=flowed specifier, and my mailer, for example, does honor it.

What happens is that your patch _is_ wrapped at 80 characters - but
it's wrapped with format=flowed (eg. with a space at the end of the
line), which means that:

 - anyone who doesn't support format=flowed is just going to see a
   broken patch wrapped at 80 characters.

 - anyone who does support format=flowed is going to see the lines
   wrapped at whatever they have specified their display- or
   wrap-width. For me this is a hard cut at 80 characters, even though
   my window is wider.

Both are incorrect behaviour, since we are not dealing with a
paragraph, but a single line which is really over 80 characters long -
and hence should be sent as such. Brane's hint about using a
preformatted paragraph is probably quite a good solution, I haven't
tested that myself - as is attaching the diffs.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 5 03:16:10 2003

This is an archived mail posted to the Subversion Dev mailing list.