Re: SVNSERVE Tests Failing

On Sat, 2003-02-01 at 18:12, Karl Fogel wrote:
> The idea is that the editor driver on the other side knows the base
> against which to apply the incoming svndiff stream -- so it uses that
> base to reconstruct the fulltext.

I understand the idea. Let's see if I can better explain the objection.

Before apply_text, the editor interface worked like plumbing. You could
take an arbitary driver and plug it into an arbitrary editor, more or
less. More interestingly, you could insert a connecting pipe between
driver and editor:

   driver --> [editor --> network --> driver] --> editor

libsvn_ra_svn/editor.c is such a connecting pipe. So was the XML
editor, before we got rid of it.

With apply_text, there is no way to build such a connecting pipe without
sending full texts over the wire. The receiving end of the connecting
pipe no longer has enough information to make editing calls.

I can see why apply_text is appealing. It moves a little bit of code
from driver to editor, and it lets us avoid deltifying over ra_local for
free (by omitting code, rather than by adding conditionals). But it
destroys an important property of the editor interface and, as a result,
will significantly complicate the ra_svn code if it stands.

If absolutely no one else agrees with me, I'll withdraw my veto. I
think I have a strong argument here, though.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 2 01:22:14 2003