Re: [PATCH] Fix Issue 1117: Send prompts to stderr

Peter Davis peter@pdavis.cx writes:
 Now, looking through one of the three *getpass implementations in that
 file, I'm confused again.

I think the point is that those implementations are only used if there
is no system getpass() available. Check out the conditional
compilation stuff around that file.

 Look at the printf just above. Before that, it prints the prompt
 to stderr, and if the password contains control chars, it uses
 stderr to print a newline and start over. But when the password
 is complete, it prints a newline to stdout. In fact, everywhere
 except that one line uses fputs(stderr).

I would guess this is just a bug in the implementation.

 Has nobody noticed this just because it uses one of the other
 implementations for most builds? Seems like the same change should
 be made here.

The bug should be fixed, but probably not many people are actually
invoking this code path anyway.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:22:36 2006