[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix issue 1118 (Was: Re: New entries file format.)

From: <peter_at_pdavis.cx>
Date: 2003-01-28 09:46:24 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[Note: I was unsure if there is a convention on whether new arguments
should always be added as the last argument -- ie., should is_attribute
come before *pool? Also, I'd appreciate if someone could run the tests
over dav, because I'm not set up to do that ATM.]

Fix for issue 1118: properly escape whitespace in XML attribute
values, and update all callers of svn_xml_escape_* to pass the new
argument.

* libsvn_subr/xml.c (xml_escape):
  New argument is_attribute. If escaping an attribute, additionally
  escape spaces, tabs, newlines, and carriage returns. Don't escape
  single- or double-quotes unless escaping an attribute.

* libsvn_subr/xml.c, include/svn_xml.h
  (svn_escape_string, svn_escape_cstring, svn_escape_stringbuf):
  New argument is_attribute, passed verbatim to xml_escape.
  
* mod_dav_svn/deadprops.c, clients/cmdline/log-cmd.c,
  libsvn_ra_dav/commit.c, libsvn_ra_dav/fetch.c:
  Update callers of svn_escape_* to use new is_attribute arg, passing TRUE
  or FALSE as appropriate.

- --
Peter Davis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+NkNhhDAgUT1yirARAkecAJ9PvZmxnmXWGMaplTZM7Zt2WnXIAgCgiQpr
8dCdYrNq3pP+8lhVo0+o+1I=
=+xm1
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

  • text/x-diff attachment: diff
Received on Sat Oct 14 02:21:40 2006

This is an archived mail posted to the Subversion Dev mailing list.