Re: svn commit: rev 4574 - in trunk/subversion: include libsvn_auth

Greg Stein wrote:

+ svn_auth_cred_simple_t *creds = apr_pcalloc (pool, sizeof(*creds));
+ simple_prompt_iter_baton_t *ibaton = apr_pcalloc (pool, sizeof(*ibaton));
+ char *username, *password;
    

Why non-const? We don't intend to change these values, and it just means
that casts are needed later. I'd recommend altering the prototype on the
prompt function, rather than letting it's non-const return value monkey
stuff like this up.

Just a general comment: You never need a cast from a non-const to a
const of the same type. I have seen some such casts in our code, but we
shouldn't perpetuate this misconception.

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org