[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: flaw in python bindings diff?

From: <cmpilato_at_collab.net>
Date: 2003-01-27 20:00:33 CET

Greg Stein gstein@collab.net writes:

  Ah...looks like Greg Stein busted this when he converted to popen2 in
  revision 4343 (strangely enough because he claimed it fixed diffs on
  files with spaces in them). Greg, can you help out a bit here?
 Switching to popen2 meant that I passed a filename as a separate
 argument, which fixes the spaces. I forgot that a filename might be
 part of those diffoptions.
 Yes, passing a list as the diffoptions is the best behavior.
 The reason to use popen2.popen2() is for security. The shell never
 sees the command string; we just directly exec() the new process with
 the right arguments. In the standard popen(), that goes to the shell
 which can then parse for redirections and whatnot -- major security

All good. Your reasons for the change were fine, and understood, and
the fix for spaces has already been made. Yay!

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:20:11 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.