Re: flaw in python bindings diff?

Michael Kefeder ml@weird-birds.org writes:

 Oh, i like the label and it's format - and it's not directly stopping
 diff from working, it's the label split apart in get_pipe() and passed
 to pipe2. I forgot to express that in a more clear way, sorry ;)

No problem.

 I understand Greg Steins intention to use popen2 but then it becomes
 tricky separating the cmd line params for diff that are given as a
 string. I'd vote for a list object as parameter to FileDiff instead of
 string, because a list is needed in the end for popen2 and imho it
 isn't complicated to create a list in python (or it's done anyway like
 in your viewcvs code). I think the right magic you mentioned will
 only introduce new bugs and take up a fair amount of coding-time.

I'll give it a shot.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:19:53 2006