[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn add horkage (and exposing libsvn_wc's ignore functionality)

From: <kfogel_at_newton.ch.collab.net>
Date: 2003-01-24 16:20:53 CET

Branko ─îibej brane@xbc.nu writes:
 Please, no. svn_config reads configuration, yes, but it doesn't
 interpret it. Putting this in svn_config breaks our interface
 separation. The ability to ignore files is a feature of the working copy
 (not even of the client!), so that get_default_ignores should go into
 svn_wc.

That was my original argument to myself about why it shouldn't go into
svn_config. But then I thought: it's *not* interpreting it. The new
interface has one function to retrieve a specific config value as a
list, and another function to tell you if a specific pattern is in the
list. Both of these are simply more fine-grained versions of what we
already do in svn_config. The config interface already reads file
data into a structure, and then provides functions to get bits of that
data out of the structure.

How a caller uses the data is another matter, of course. It's not
svn_config that's actually ignoring the files, it's still svn_wc.

If you want to move it, that's fine. Actually, my alternative was to
put it in svn_client, since client implementations might want to know
if a file is in the ignore space or not. But heck, svn_wc works too.
I don't see a clear right answer here; we could also wait until
calling patterns make it clear, and then move it.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:13:39 2006

This is an archived mail posted to the Subversion Dev mailing list.