Re: svn add horkage (and exposing libsvn_wc's ignore functionality)

Karl Fogel wrote:

Branko Čibej brane@xbc.nu writes:
  

Please, no. svn_config reads configuration, yes, but it doesn't
interpret it. Putting this in svn_config breaks our interface
separation. The ability to ignore files is a feature of the working copy
(not even of the client!), so that get_default_ignores should go into
svn_wc.
    

That was my original argument to myself about why it shouldn't go into
svn_config. But then I thought: it's *not* interpreting it. The new
interface has one function to retrieve a specific config value as a
list, and another function to tell you if a specific pattern is in the
list. Both of these are simply more fine-grained versions of what we
already do in svn_config. The config interface already reads file
data into a structure, and then provides functions to get bits of that
data out of the structure.

O.K., then let's instead get a generic interface for parsing option
values into lists of thingies. In other words, let's not call it get
ignore pattens, so that we can use the function for other listy
options, too.

How a caller uses the data is another matter, of course. It's not
svn_config that's actually ignoring the files, it's still svn_wc.

Sure, that's why svn_config shouldn't be saying out loud that it's
retrieving a list of things to ignore.

If you want to move it, that's fine. Actually, my alternative was to
put it in svn_client, since client implementations might want to know
if a file is in the ignore space or not. But heck, svn_wc works too.
I don't see a clear right answer here; we could also wait until
calling patterns make it clear, and then move it.
  

I'd say svn_client +0, svn_wc +1, svn_config -0.6931

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org