[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Issue 898 atomic rename, implement svn_fs_rename

From: <rassilon_at_lyra.org>
Date: 2003-01-24 06:13:40 CET

 From: Bill Tutt [mailto:rassilon@lyra.org]
 
  From: cmpilato@collab.net [mailto:cmpilato@collab.net]
  Bill Tutt rassilon@lyra.org writes:
  
   This gives us at least two interesting choices:
   1)
   * Keep committed-path on node-revision.
   * Add path back to changes table on the branch, but make it
  optional
   for everything but renames.
   
   This allows us not to bother recording committted path
 changes on
   bubbled up directories, but it has the side-efffect of
  increasing the
   cost of tree - dag mapping in open_path in tree.c.
  (specifically the
   get_id_path routine).
   

I'm going to fold Philip's patch and suggestion #1 into my WC of the
1003 branch, and see if I can't add some test cases to make sure I get
this new open_path logic twist right.

It'll probably be a day or so before I commit this stuff to the 1003
branch, so if anyboy has any other issues they can think of, or a better
idea please speak up. :) Note: I don't plan on solving the WC, svn log
output, or svn_fs_node_revisions_changed API issues with this
particular set of changes. Just going to ensure that the core
tree.c:open_path code path can handle the rename problem.

FYI,
Bill

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:12:23 2006

This is an archived mail posted to the Subversion Dev mailing list.