Re: [PATCH] Issue 898 atomic rename, implement svn_fs_rename

cmpilato@collab.net wrote:

For example, I was thinking that we could avoid a schema change for
svn_fs_rename() by using information slots we (will) already have
(after 1003 goes in):

   changes table: Add new rename change type.

   nodes table: The committed-path tells you what the new path is.
                  the source-noderev-id points to the previous
                  incarnation, and that node's committed-path tells you
                  what the source path was. We know that this isn't a
                  copy because nothing was added to the copies table.

Er, that won't work. We can't go changing the node's committed-path
after a rename, because the rename doesn't touch that node at all. The
node's committed-path will always tell us what the /source/ of the
/first/ rename was, but you can rename the file several times and not
create a new node; e.g.,

    svn mv foo bar; svn ci; svn mv bar qux/baz; svn ci;

Now, qux/baz points to a node-change whose committed-path is foo, and
we don't even have a node-change with committed-path bar anywhere.

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org