[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn add horkage (and exposing libsvn_wc's ignore functionality)

From: <kfogel_at_newton.ch.collab.net>
Date: 2003-01-23 00:55:23 CET

Eric Gillespie epg@pretzelnet.org writes:
 I have many of those files in global-ignores:
 
 global-ignores = *.o *.lo *.la *.al .libs .so* .a #*# .*.rej *.rej .*~ *~ .#*
 
 svn add should not add those files.

Jon Trowbridge just noticed this too; I think he was going to (maybe
has?) file an issue. Those ignores should be honored, yes.

 Well, i was going to have a patch with this message, but it looks
 like the ignore functionality is completely hidden in libsvn_wc.
 It looks like it was expected that only svn status would need
 this functionality. At least some of it should be exposed.
 
 I was going to add a test to see if the item is to be ignored in
 libsvn_client/add.c:add_dir_recursive right after the check for
 '.svn', '.', and '..'. But to do that i need a function like
 svn_wc_is_ignored.
 
 Of course, another way to do it would be to have svn_wc_add call
 get_default_ignores and check for this itself. But that seems
 the wrong place to do it, to me. Furthermore, i still think
 libsvn_wc should expose the ignore functionality. Even if it
 turns out the svn program never does anything with it, other
 clients may find it useful.
 
 How does that sound?

Yes, it sounds good to me. Let's make it public. Still planning to
write the patch?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:08:01 2006

This is an archived mail posted to the Subversion Dev mailing list.