Re: [PATCH] Issue 898 atomic rename, implement svn_fs_rename

Philip Martin wrote:

Hello

While trying to determine what implementing atomic rename would
involve I discovered an interface without an implementation. It
looked fairly straightforward to complete it, but I may well have made
some stupid mistakes.

Philip, we love you. Your implementation looks entirely sane to me.

In particular, is it correct to record an add and a delete in the changes table?

Ah, yes, that. I've been wondering about that myself, and it seems wrong
to record an add and delete if we're not, in fact, doing that. I'd
rather introduce rename-source and rename-target records; the -source
should somehow contain the target path, and the -target should contain
the source path, so that we can follow the rename in both directions.

But I don't know how these new records would affect things like log,
update, merge, ...

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org