RE: [PATCH] make symlinked hook scripts work again

Philip Martin <philip@codematters.co.uk> writes:
> Josef Wolf <jw@raven.inka.de> writes:

> > * subversion/libsvn_subr/io.c
> > (svn_io_check_path): Add boolean parameter 'resolve_symlinks' to
> > decide whether the target of a symlink or the symlink
> > itself should be checked.

> Even when/if Subversion starts to version symbolic links it will be
> rare for the code to allow some path to be either a file or a link.
> In most cases things that should be files cannot be links, and things
> that should be links cannot be files.

Are you sure about this? Usually (read: in non-svn-world) you rarely
care whether a path is actually a real file or a symlink. Sure, svn
has different requirements. But do you think that the common case in
the non-svn world is that rare for svn that it would be worth to
broaden the API?

> Thus I'm not sure adding a
> boolean parameter is the best solution, perhaps the svn_io_check_path
> interface should remain unchanged, and there should be a function with
> a different name but the same parameters that provides the
> resolve_symlinks == TRUE behaviour. (These functions could call a
> common helper function of course.)

I did it this way because that was what Karl suggested in
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=28522

> I don't know if this is better, but it should be considered.

At least, it would make the patch _a lot_ smaller :-)

So I will post an alternate patch tonight.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 14 09:59:03 2003