RE: [PATCH] make symlinked hook scripts work again

Karl Fogel wrote:
 Josef Wolf jw@raven.inka.de writes:

    (svn__io_check_path): Rename from svn_io_check_path() and add new
      paramter 'resolve_symlinks' to handle both, svn_io_check_path()
      and svn_io_check_resolved_path().
 
 I'm applying this now, Josef, thanks! Just a quick note:

Thank you!

 'svn__io_check_path' is a strange name :-).

Yes. I stumbled while I was thinking out a name for that function.
And I remembered that I read somewhere in the svn-source-tree about
conventions how functions should be named. But I could not find
that passage anymore. Now that I looked again, it is in the
Other conventions section.

 Since this is entirely internal static, I'll change it to `io_check_path'.

Thanks!

 But if it were internal exported, it should have been `svn_io__check_path'
 anyway.

I'll try to remember :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:13:15 2006