[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] default to --no-auth-cache

From: <rbb_at_rkbloom.net>
Date: 2003-01-13 22:16:43 CET

On 13 Jan 2003, Philip Martin wrote:

> <rbb@rkbloom.net> writes:
>
> > I am sending a patch that switches the default behavior to
> > --no-auth-cache. This removes that command-line option, and adds a new
> > one --auth-cache, which as you would expect, turns the cache back on.
>
> You didn't provide a log message :-(

Sorry, most of the projects I have been involved with don't ask for one.
Here it is:

Change the default behavior of the client to not cache authentication
information. This can be enabled by passing --auth-cache

>
> > Ryan
> >
> >
> > Index: subversion/libsvn_subr/config_file.c
> > ===================================================================
> > --- subversion/libsvn_subr/config_file.c (revision 4297)
> > +++ subversion/libsvn_subr/config_file.c (working copy)
> > @@ -737,10 +737,10 @@
> > "### how to use this file.\n"
> > "\n"
> > "### Section for authentication and authorization customizations.\n"
> > - "### Set store-password to 'no' to avoid storing your subversion\n"
> > - "### password in your working copies. It defaults to 'yes'.\n"
> > + "### Set store-password to 'yes' to avoid being prompted for your\n"
> > + "### subversion password. It defaults to 'no'.\n"
> > "# [auth]\n"
> > - "# store-password = no\n"
> > + "# store-password = yes\n"
>
> Are you aware that the store-password setting is separate from the
> --no-auth-cache option? Suggesting that the user sets store-password
> to yes is silly, that's already the default and your patch doesn't
> change it.
>
> Here's how the current code works: whether auth data is stored is
> controlled by the --no-auth-cache command line option. The
> store-password setting is only relevant if auth data is being stored.
> If auth data is being stored then the username is always stored, but
> the password is only stored if store-password allows.
>
> So did you mean to change the store-password behaviour?

Okay, I read the docs incorrectly. No, this shouldn't be changed. Of
course, I find this rather confusing. Basically, you are saying that it
is possible to pass --auth-cache on the command line, and still not have
their password cached, based on what store-password is set to. Why are
there two different options for how this works? IMHO, the store-password
setting should just be toggling whether the client defaults the
--auth-cache option.

Ryan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 13 22:03:34 2003

This is an archived mail posted to the Subversion Dev mailing list.