Re: [PATCH] default to --no-auth-cache

<rbb@rkbloom.net> writes:

> I am sending a patch that switches the default behavior to
> --no-auth-cache. This removes that command-line option, and adds a new
> one --auth-cache, which as you would expect, turns the cache back on.

You didn't provide a log message :-(

> Ryan
>
>
> Index: subversion/libsvn_subr/config_file.c
> ===================================================================
> --- subversion/libsvn_subr/config_file.c (revision 4297)
> +++ subversion/libsvn_subr/config_file.c (working copy)
> @@ -737,10 +737,10 @@
> "### how to use this file.\n"
> "\n"
> "### Section for authentication and authorization customizations.\n"
> - "### Set store-password to 'no' to avoid storing your subversion\n"
> - "### password in your working copies. It defaults to 'yes'.\n"
> + "### Set store-password to 'yes' to avoid being prompted for your\n"
> + "### subversion password. It defaults to 'no'.\n"
> "# [auth]\n"
> - "# store-password = no\n"
> + "# store-password = yes\n"

Are you aware that the store-password setting is separate from the
--no-auth-cache option? Suggesting that the user sets store-password
to yes is silly, that's already the default and your patch doesn't
change it.

Here's how the current code works: whether auth data is stored is
controlled by the --no-auth-cache command line option. The
store-password setting is only relevant if auth data is being stored.
If auth data is being stored then the username is always stored, but
the password is only stored if store-password allows.

So did you mean to change the store-password behaviour?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org