[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4317 - trunk/tools/hook-scripts

From: ender <ender_at_objectrealms.net>
Date: 2003-01-10 02:17:16 CET

On Thursday 09 January 2003 04:41 pm, Branko Čibej wrote:
> ender wrote:
> >On Thursday 09 January 2003 04:00 pm, Branko Čibej wrote:
> >>gstein@tigris.org wrote:
> >>>+#
> >>>------------------------------------------------------------------------
> >>>+# TODO
> >>>+#
> >>>+# * pipe output into a mail program (and avoid os.popen)
> >>
> >>Wouldn't using the smtplib.SMTP class be best? Then the mailer.py script
> >>wouldn't depend on the availability of a particular (unix) mail program.
> >
> >moving to smtp would definitely be better for portability, but another
> > issue is that by using the (unix) mail program (s), you can inject
> > directly into the mta queue, which for some edge cases is a better thing
> > to do if a direct smtp socket connection is not possible such that the
> > message isn't lost.
>
> It also makes the script terminally impossible to use on Windows. Well,
> either that, or introduce platform-specific code there. Is making a SMTP
> connection to localhost much different than piping through mailx?

imo, its better to go with smtp for portability, and the possibility of
directing to non local mailhosts, previously, i just wanted to bring up one
possible reason, why going through a mailer program would be better... ie if
the mailer program did direct injection into the mta queue, than it would be
more robust in cases of server or network problems. on a whole using smtplib
gives a bit more flexibility and portability.

-e

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 10 02:15:09 2003

This is an archived mail posted to the Subversion Dev mailing list.