Re: svn commit: rev 4317 - trunk/tools/hook-scripts

ender wrote:

>On Thursday 09 January 2003 04:00 pm, Branko Čibej wrote:
>
>
>>gstein@tigris.org wrote:
>>
>>
>>>+#
>>>------------------------------------------------------------------------
>>>+# TODO
>>>+#
>>>+# * pipe output into a mail program (and avoid os.popen)
>>>
>>>
>>Wouldn't using the smtplib.SMTP class be best? Then the mailer.py script
>>wouldn't depend on the availability of a particular (unix) mail program.
>>
>>
>
>moving to smtp would definitely be better for portability, but another issue
>is that by using the (unix) mail program (s), you can inject directly into
>the mta queue, which for some edge cases is a better thing to do if a direct
>smtp socket connection is not possible such that the message isn't lost.
>
>

It also makes the script terminally impossible to use on Windows. Well,
either that, or introduce platform-specific code there. Is making a SMTP
connection to localhost much different than piping through mailx?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org