Re: [PATCH] make symlinked hook-scripts work again

Josef Wolf <jw@raven.inka.de> writes:

> Third case:
> ===========
> $ touch foo bar
> $ svn add bar
> A bar
> $ rm bar
> $ ln -s foo bar
> $ svn ci -m test
> Adding bar
> Transmitting file data .
> Committed revision 1.
>
> Does everybody agree that this should be bombed out?

That should not commit. When I try it, it does not commit

$ svnadmin create repo
$ svn co file://`pwd`/repo wc
$ svn add wc/bar
$ rm wc/bar
$ ln -s wc/foo wc/bar
$ svn ci wc
Adding wc/bar
Transmitting file data .../svn/subversion/libsvn_client/commit.c:669: (apr_err=2)
svn: No such file or directory
svn: Commit failed (details follow):
../svn/subversion/libsvn_subr/io.c:301: (apr_err=2)
svn: svn_io_copy_file: error copying /home/pm/sw/subversion/obj/wc/bar to /home/pm/sw/subversion/obj/wc/.svn/tmp/text-base/bar.svn-base.62956.00001.tmp
../svn/subversion/clients/cmdline/util.c:306: (apr_err=2)
svn: Your commit message was left in a temporary file:
   /home/pm/sw/subversion/obj/wc/svn-commit.63104.00001.tmp

Is your patch responsible for allowing that to commit? Whether it's
your patch or not, relying on an apr_file_copy error is not very good,
Subversion should detect the problem earlier.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org