Re: [PATCH] make symlinked hook-scripts work again

On Thu, Jan 09, 2003 at 12:37:38AM +0100, Josef Wolf wrote:

Hello again...

> Here comes the patch to the symlink-issue discussed in the thread
> "CGI for repository administration". This patch is relative to r4296.
> It passes the "make check" with no errors and behaves exactly the same
> as unpatched r4296 on the three cases mentioned by Philip.

I decided not to include changes to those three cases for two reasons:

1. IMHO it would be a bad idea to mix such a large (though trivial)
   change with an other change.
2. I think the proper behavior in those cases should be discussed first
   on the list.

OK, now let's go to the discussion:

The first case:
===============
$ cd wc
$ touch foo bar
$ ln -s foo baz
$ svn add baz
/home/jw/local/l/subvers/src/svn/subversion/libsvn_wc/adm_ops.c:785: (apr_err=200007)
svn: Trying to use an unsupported feature
svn: Unsupported node kind for path 'baz'.

Looks sane to me.

Second case:
============
$ touch foo bar
$ svn add bar
A bar
$ rm bar
$ ln -s foo bar
$ svn st
? foo

Should this be aborted? IMHO this would be too harsh.
Should it just print "? bar" additionally? Bad idea, too. This
could easily be overseen.

Third case:
===========
$ touch foo bar
$ svn add bar
A bar
$ rm bar
$ ln -s foo bar
$ svn ci -m test
Adding bar
Transmitting file data .
Committed revision 1.

Does everybody agree that this should be bombed out?

-- 
-- Josef Wolf -- jw@raven.inka.de --
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org