At Tue, 7 Jan 2003 19:54:51 -0500,
Garrett Rooney wrote:
>
> On Tuesday, January 7, 2003, at 01:40 PM, Fumitoshi UKAI wrote:
> >
> > * subversion/bindings/ruby/client.c
> > (cl_log_message_func): add tmp_file arugments because it is
> > svn_client_get_commit_log_t.
> > It doesn't use tmp_file, so it sets NULL.
> > (cl_propget): revision and auth_baton are required by
> > svn_client_propget().
> > (cl_proplist): revision and auth_baton are required by
> > svn_client_proplist().
>
> i'm about to apply these changes.
>
> > * subversion/bindings/ruby/extconf.rb
> > add comments how to build in build tree.
> > hack to use libtool in case ruby binding built in build tree.
> > Some local libs (-lgdbm, -lexpat, -ldb-4) are required,
> > but missing from apr-config. Without this hack, have_library()
> > failed.
> > Add build tree to LDFLAGS to link library currently built.
> > Add subversion/include to include path.
> > library name fixes: s/apr-0/apr/, s/aprutil-0/aprutil/.
> > Except classical apr path layout, no -0 suffix is used.
> >
>
> i left the extconf.rb changes off, since most of them seem like hacks,
> and even if we hack it to support building with the in-tree svn libs,
> it didn't seem to work for the in-tree apr/aprutil.
>
> also, what did you use to generate the patch? it seems like some weird
> mix between a unified diff and a context diff, and i couldn't get it to
> apply here.
I just use 'svn diff -x -u -x --show-c-function' in trunk dir.
Regards,
Fumitoshi UKAI
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 8 04:21:16 2003