[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash on removal (w/ locking)

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-01-07 22:15:15 CET

On Tue, Jan 07, 2003 at 11:46:35AM -0800, Justin Erenkrantz wrote:
>...
> >> The relevant portion of the stack trace:
> >>
> >> Program received signal SIGSEGV, Segmentation fault.
> >> 0x403f9c17 in dav_auto_checkin (r=0x8191af0, resource=0xbffff714,
> >> undo=0, unlock=1, av_info=0x0) at util.c:2022
> >> 2022 if (av_info->parent_resource != NULL &&
> >> av_info->parent_resource->working
> >> (gdb) bt
> >> # 0 0x403f9c17 in dav_auto_checkin (r=0x8191af0,
> >> # resource=0xbffff714,
> >> undo=0,
> >> unlock=1, av_info=0x0) at util.c:2022
> >> # 1 0x403fa3ee in dav_unlock_walker (wres=0xbffff704, calltype=1)
> >> at util_lock.c:423
>
> We can add a simple non-NULL check against av_info, but I have no
> clue if that is the *right* thing to do here. Oh, Greg?? -- justin

I've fixed up the code in mod_dav's util.c and checked it into the 2.0 and
2.1 branches. Since you're using 2.1-dev (httpd HEAD), then you can simple
update from CVS to pick up the fix.
(httpd-2.0/modules/dav/main/util.c to be specific)

Basically, that section of the code deals with auto-checkin for a parent
resource (for example, if you check out the parent to do a MKCOL or a PUT).
But in the unlock case, we aren't concerned at all with parents. Thus, I
reorg'd the code to only fire when unlock==0.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 7 22:14:18 2003

This is an archived mail posted to the Subversion Dev mailing list.