Re: Buglet expanding keywords

On Sun, Jan 05, 2003 at 11:29:19PM -0600, Karl Fogel wrote:
> Looks good to me, thanks for doing this! I haven't run make check or
> anything, assume you did that :-).

Indeed, I did, that's how I found the testcase that needed changing
:-)

> > - "Line 46: Invalid $Rev:$ is missing a space.",
> > + "Line 46: Valid $Rev:$ is not missing a space.",
> > "Line 47: fairly boring subst test data... blah blah.",
>
> Shouldn't that be "Valid $Rev:$ is missing a space"? (That is, lose
> the "not".)

One could argue that since it is valid as is it isn't missing a space
(In fact that is what I was thinking.). If it were missing something
that would imply something was wrong. . . In any case I'll drop the
'not' and commit shortly since I don't feel strongly either way.

This reminds me of another minor inconsistency. When subversion writes
unexpanded keywords it writes them like '$keyword: $'. It adds a
colon and a space. Is there a reason that subversion doesn't unexpand
keywords to '$keyword$'? Since the documentation describes unexpanded
keywords as '$keyword$' that would be the more obvious choice, IMO.

-David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 6 16:10:50 2003