[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Buglet expanding keywords

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-01-06 06:29:19 CET

David Kimdon <dwhedon@debian.org> writes:
> Here's a fix for the keyword issue. I took a look at
> doc/book/book/ch06.xml and the other docs and didn't see anything that
> needs to be updated. If we are in agreement that this is something we
> want to do (I'd like to see it changed as well), and the patch looks
> good I'll commit the fix.

Looks good to me, thanks for doing this! I haven't run make check or
anything, assume you did that :-). A quick comment about the test
changes:

> Index: subversion/tests/libsvn_wc/translate-test.c
> ===================================================================
> --- subversion/tests/libsvn_wc/translate-test.c (revision 4265)
> +++ subversion/tests/libsvn_wc/translate-test.c (working copy)
> @@ -93,7 +93,7 @@
> "Line 43: fairly boring subst test data... blah blah.",
> "Line 44: fairly boring subst test data... blah blah.",
> "Line 45: Invalid $LastChangedRevisionWithSuffix$, started unexpanded.",
> - "Line 46: Invalid $Rev:$ is missing a space.",
> + "Line 46: Valid $Rev:$ is not missing a space.",
> "Line 47: fairly boring subst test data... blah blah.",

Shouldn't that be "Valid $Rev:$ is missing a space"? (That is, lose
the "not".)

> + if (rev)
> + {
> + if (expand)
> + {
> + expect[46 - 1] =
> + apr_pstrcat (pool, "Line 46: ", "Valid $Rev: ", rev,
> + " $ is not missing a space.", NULL);
> + }
> + /* Else Line 46 remains unchanged. */
> + }
> +

Oh, I see, one could interpret the sentence as applying to the
post-expansion data, not the pre-expansion. But I *think* they
generally refer to the pre-expansion string, don't they? Check the
other tests, I just wanted to point out the possibility...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 6 07:13:42 2003

This is an archived mail posted to the Subversion Dev mailing list.