Re: [PATCH] svn-fast-time-from-cstring.patch

Brandon Ehle <azverkan@yahoo.com> writes:

> >If I look at /usr/local/apache2/include/httpd.h it says
> >
> > /** strtoul does not exist on sunos4. */
> > #ifdef strtoul
> > #undef strtoul
> > #endif
> > #define strtoul strtoul_is_not_a_portable_function_use_strtol_instead
> >
> >Perhaps we should use strtol into a temporary, and check for -ve
> >values.
>
> Doesn't matter either way because it won't overrun for millions of
> years,

I was thinking more of rejecting ill-formed input such as

2002--9--6T01:05:05.000000

I don't suppose it matters if apr_implode_time will reject it.

> I had just read somewhere that strtoul was more portable that
> strtol.

We already use strtol, we don't use strtoul.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org