[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Sanity check: removing src_err

From: Glenn A. Thompson <gthompson_at_cdr.net>
Date: 2002-12-10 07:36:51 CET

By the way,
What's your beef with it? I seem to remember a previous post wanting to
put a bullet in it:-)
What grief does it cause?

gat

Glenn A. Thompson wrote:

> Hey,
> How do you plan on detecting DEADLOCK Errors?
> I planned on using it quite a bit for the Abstracted SQL DB stuff.
> In fact I already have code which uses that field to deal with DB
> specifc error codes in abstracted ways.
> If you remove, please suggest something to take it's place.
> If you look through my mega FS patch you will see that I have also
> abstracted it's use for trail.c
> I refer to it in some sort of is_retryable callback implemented as a
> vtable function.
> I'm not sure what I would do without it.
> http://www.cdrguys.com/subversion/index.html
> I am going to start spliting that thing up into smaller pieces this week.
>
>
> gat
>
> Greg Hudson wrote:
>
>> I mentioned this in an unrelated thread and got a +1 from Karl, but
>> I'd like to give people a chance to -1 before I go ahead and do it.
>>
>> I'd like to remove the src_err field of svn_error_t. We set it in 16
>> places and use it in one place (libsvn_fs/trail.c line 141; I'm not
>> including printing it out in svn_handle_error when SVN_DEBUG is set).
>> We set it variously to errno (7 places), APR_FROM_OS_ERROR() of a
>> Windows error (4 places), an APR error (3 places), and a Berkeley DB
>> error (2 places).
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: dev-help@subversion.tigris.org
>>
>>
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 10 07:35:42 2002

This is an archived mail posted to the Subversion Dev mailing list.