[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4013 - trunk/subversion/tests/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-12-06 00:45:49 CET

Karl Fogel wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>>Ah, that's an easy one. I tried and failed.
>>
>>It's not just the tests themselves; the tree comparison code would also
>>have to read the files in binary mode. When I did that, other tests
>>started failing because they new contents in text mode. Et cetera ad
>>nauseam. So instead of fixint the whole test suite to be binary-safe, I
>>threw away that lovely PNG.
>>
>>
>
>Huh. I would think that's a test-suite bug right there -- the test
>suite should not need need to read test data in text mode to succeed.
>I mean, we're comparing bit strings here. How hard can this be? :-)
>
>

It's not necessarily hard, but it involves checking every file read and
write operation in the whole test suite -- for a start. That's a huge
amount of work.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 6 00:46:47 2002

This is an archived mail posted to the Subversion Dev mailing list.