Re: svn commit: rev 3983 - in trunk: . subversion/include subversion/libsvn_ra_svn subversion/svnserve

Greg Hudson wrote:

>My reasoning is that prefixing is for libraries; svnserve is an
>application. (libsvn_ra_svn does use an ra_svn prefix on its vtable
>functions.)
>
Right. change that back, except the log -> log:_cmd rename.

>>>Unless we have a tree-wide style policy on this point, I'd prefer if
>>>you wouldn't reformat these function declarations.
>>>
>>>
>>As a matter of fact, we _do_ have a style policy, it just so happens that both
>>Gregs tend to ignore it. :-)
>>
>>
>
>Huh. Okay, I will go back and reformat all the other function
>declarations to match. But I'm going to punt the prefix on the svnserve
>command handlers.
>
>
No, don't bother reformatting all the declarations. We're not
_completely_ consistent, anyway; mod_dav_svn is a case in point. Like I
said, I reformatted those decls to make them fit into 80 columns (after
the rename), not because of some philosophical reason.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org