[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Editor contract question

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-05 06:56:19 CET

[Sorry for the late response, Greg. We had some mail server trouble,
and I'm just seeing some mails that were sent days ago.]

Greg Hudson <ghudson@MIT.EDU> writes:
> libsvn_repos/delta.c:delete() invokes editor->delete_entry with an
> invalid revision argument:
>
> return c->editor->delete_entry (edit_path (c, path), SVN_INVALID_REVNUM,
> dir_baton, pool);
>
> The documentation for delete_entry is:
>
> Remove the directory entry named PATH, a child of the directory
> represented by PARENT_BATON. REVISION is used as a sanity check
> to ensure that you are removing the revision of PATH that you
> really think you are.
>
> There is no mention that REVISION can be invalid if the sanity check
> is not required, so when I wrote my ra_svn code, I didn't make
> allowances for passing an invalid revision.

I think that doc string should say that if REVISION is invalid, it is
ignored. Same with open_directory and open_file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 5 07:34:36 2002

This is an archived mail posted to the Subversion Dev mailing list.