[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug: Control char in commit message

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-04 19:56:53 CET

John Barstow <John_Barstow@gfsg.co.nz> writes:
> For ease of processing, may I suggest that characters invalid in XML 1.0 be
> considered invalid for log messages and filenames? That way, generating XML
> views of the repository won't die horribly.
> http://www.w3.org/TR/REC-xml#charsets has the list of valid characters.

But the client layer shouldn't even let things get that far, because
it should be trying to convert to UTF-8. If it succeeds, the result
is XML-safe. If it fails, the commit doesn't proceed anyway.

I'm not saying the server can't guard against bad chars as well, but
in this particular case, there's also the question "Why didn't the
client fail before the server even saw the data?"

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 20:34:59 2002

This is an archived mail posted to the Subversion Dev mailing list.