[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Bug: Control char in commit message

From: John Barstow <John_Barstow_at_gfsg.co.nz>
Date: 2002-12-04 20:35:59 CET

>I have no good suggestion how this interface *should* work

For ease of processing, may I suggest that characters invalid in XML 1.0 be
considered invalid for log messages and filenames? That way, generating XML
views of the repository won't die horribly.
http://www.w3.org/TR/REC-xml#charsets has the list of valid characters.

As far as handling submissions containing invalid characters (whatever we
decide they should be) I see three options:

1) Strip them out.
2) Replace them with a '?' or other character to indicate they were
replaced.
3) Refuse them outright.

I think 3 should be the conservative default, but I think we should allow
people to configure their client to do 1 or 2. With a warning message, of
course.

John C Barstow

PS. Just saw the Apache error. Looks like XML validation is already
affecting svn, so adding the extra check up front would be a good thing.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 20:30:43 2002

This is an archived mail posted to the Subversion Dev mailing list.