Re: Bug: Control char in commit message

>>>>> On 04 Dec 2002 08:46:03 -0600, Karl Fogel <kfogel@newton.ch.collab.net> said:

> Thanks for the investigation!
> The log message is being recoded from locale to UTF-8 for commit. So
> that's one step that can fail. Assuming it does not fail (that is,
> the conversion returns success, even though the source may be a bunch
> of bogus characters that just happen to all have encodings within the
> locale), then the UTF-8 should be able to be applied over any ra
> layer. If it can't be sent, that's a bug.

> I'm not sure exactly where or why your commit failed. It was a recent
> version of svn, right?

Yes, rev. 3953.

> Can you trace the error to the line in source
> where it happens? We probably should file an issue for this, but
> let's drill down a bit first.

Maybe this error message from the apache error_log helps?

    [Wed Dec 04 13:07:53 2002] [error] [client 127.0.0.1] XML parser error code: not well-formed (invalid token) (4)

I cannot run my server under gdb unless you give me detailed
instructions how to do that. Here's a short test case:

    % svn co http://localhost/svn/test test-wc
    k's password:
    
    Checked out revision 0.
    % cd test-wc
    % echo foo > foo
    % svn add foo
    A foo
    % svn ci -m '^H'
    subversion/libsvn_client/commit.c:655: (apr_err=175002, src_err=0)
    svn: RA layer request failed
    svn: Commit failed (details follow):
    subversion/libsvn_ra_dav/util.c:81: (apr_err=175002, src_err=0)
    svn: applying log message to /svn/test/!svn/wbl/6dc2176b-fbb0-0310-9734-e6136f8a9d49/0: 400 Bad Request
    

I find this error message in ./srclib/apr-util/xml/apr_xml.c in the
APR-UTIL sources:

    case APR_XML_ERROR_EXPAT:
        (void) apr_snprintf(errbuf, errbufsize,
                            "XML parser error code: %s (%d)",
                            XML_ErrorString(parser->xp_err), parser->xp_err);
        return errbuf;

This is what I find in the XML standard
(http://www.w3.org/TR/REC-xml#charsets):

    Character Range
    [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */
    
Does this ring a bell?

-- 
andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org