[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug: Control char in commit message

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-04 15:46:03 CET

Thanks for the investigation!

The log message is being recoded from locale to UTF-8 for commit. So
that's one step that can fail. Assuming it does not fail (that is,
the conversion returns success, even though the source may be a bunch
of bogus characters that just happen to all have encodings within the
locale), then the UTF-8 should be able to be applied over any ra
layer. If it can't be sent, that's a bug.

I'm not sure exactly where or why your commit failed. It was a recent
version of svn, right? Can you trace the error to the line in source
where it happens? We probably should file an issue for this, but
let's drill down a bit first.

Thanks,
-Karl

andreas.koenig@anima.de (Andreas J. Koenig) writes:
> Following up to my own bugreport (^H not allowed in commit message):
>
> To provide further evidence, I checked commit messages with all
> 256 characters and found that
>
> 1. 0x0 is allowed but is interpreted as end of string, so all
> characters after it are cut off
>
> 2. decimal character positions 1-8, 11-12, 14-31 are disallowed
>
> 3. Control-M (0xd) may lead to troubles if svn decides that you have
> "inconsistent line-endings in source stream, repair flag is off."
>
> I have no good suggestion how this interface *should* work, I'll do my
> escaping according to the findings above with perl
>
> s/([\000-\010\013-\037])/"^".pack("c",ord($1)^64)/eg;
>
> and recommend others to do likewise until this issue is resolved.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 16:24:23 2002

This is an archived mail posted to the Subversion Dev mailing list.