[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_fs__parse_skel prototype question

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-12-04 02:20:51 CET

Colin Watson <cjwatson@flatline.org.uk> writes:

> On Tue, Dec 03, 2002 at 01:14:29PM -0800, Greg Stein wrote:
> > On Tue, Dec 03, 2002 at 02:10:01PM -0500, Greg Hudson wrote:
> > > On Tue, 2002-12-03 at 13:23, Philip Martin wrote:
> > > > I don't understand the comment about not using 'const char*' for DATA.
> > > > If svn_fs__parse_skel is not going to change DATA then 'const char*'
> > > > is exactly what is wanted, and making it const in no way constrains
> > > > the callers.
> > >
> > > The created skel will point into DATA, not a copy of it. Data pointed
> > > to by skels can be modified. (I don't know if we ever do modify data
> > > pointed to by skels, and I'd say our lives would be safer if skels were
> > > immutable, but that's not how things are right now.)
> >
> > I agree, and wanted to do this change a long while ago. I think that at one
> > point, I *did* change skel->data to be constant, but Jim backed it out.
>
> My copy of libsvn_fs/util/skel.h has 'const char *data' in skel_t, and
> it seems to have been that way since libsvn_fs/skel.h in r1. Am I
> missing something?

Whatever it is, I'm missing it as well :)

I'm currently using a patch that changes the DATA parameter to
svn_fs__parse_skel into 'const char *', and removes some casts that
are then no longer needed. It all seems to work...

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 02:21:32 2002

This is an archived mail posted to the Subversion Dev mailing list.