Re: svn commit: rev 3935 - trunk/subversion/clients/cmdline

On Sunday, December 1, 2002, at 05:44 PM, Philip Martin wrote:

> rooneg@tigris.org writes:
>
>> Author: rooneg
>> Date: 2002-11-29 16:17:24 -0600 (Fri, 29 Nov 2002)
>> New Revision: 3935
>>
>> Modified:
>> trunk/subversion/clients/cmdline/main.c
>> Log:
>> Patch from Andy McCarty <mccarw@lom.med.va.gov>
>>
>> * subversion/clients/cmdline/main.c
>> (svn_cl__cmd_table): add --username and --password arguments to
>> 'svn cat'.
>>
>>
>> Modified: trunk/subversion/clients/cmdline/main.c
>> ======================================================================
>> ========
>> --- trunk/subversion/clients/cmdline/main.c (original)
>> +++ trunk/subversion/clients/cmdline/main.c Fri Nov 29 16:17:29 2002
>> @@ -126,7 +126,7 @@
>> { "cat", svn_cl__cat, {0},
>> "Output the content of specified files or URLs.\n"
>> "usage: cat TARGET [TARGET [TARGET ... ]]\n",
>> - {'r'} },
>> + {'r', svn_cl__auth_username_opt, svn_cl__auth_password_opt} },
>
> Any reason you didn't add non_interactive and no_auth_cache?
>
> I wonder if these four options should be combined into one macro
>
> #define SVN_AUTH_OPTS \
> svn_cl__auth_username_opt, \
> svn_cl__auth_password_opt, \
> svn_cl__no_auth_cache_opt, \
> svn_cl__non_interactive_opt

no real reason, it just didn't occur to me. i agree, we should
probably combine them, since it is too easy to forget one of the four.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're
rooneg@electricjellyfish.net      sufficiently snide about becomes
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org