Re: svn commit: rev 3912 - in trunk/subversion: libsvn_subr tests/libsvn_subr

cmpilato@tigris.org writes:
...
> +static svn_boolean_t
> +char_is_uri_safe (int c)
> +{
> + /* Is this an alphanumeric character? */
> + if (((c >= 'A') && (c <='Z'))
> + || ((c >= 'a') && (c <='z'))
> + || ((c >= '0') && (c <='9')))
> + return TRUE;
> +
> + /* Is this a supported non-alphanumeric character? (these are sorted
> + by estimated usage, most-to-least commonly used) */
> + if (strchr ("/:.-_!~'()@=+$,&*", c) != NULL)
> + return TRUE;
> +
> + return FALSE;
> +}
...

Not positive what the SVN style is, but I generally just return
directly:

  return (strchr ("/:.-_!~'()@=+$,&*", c) != NULL);

Compresses 3 statements into 1 and is still very readable.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org