Re: Entries Cache Performance

Brandon Ehle <azverkan@yahoo.com> writes:

> > You may like to try the following patch. It should parse the file
> > only once when there is a write lock.
>
> I'm seeing about a 14% speed boost with this patch.

Is that elapsed time or CPU or both? Which operation?

I don't see as much as that, I get about 4-5% CPU savings for an
update which changes 500 out of 1000 files spread over 340
directories.

>
> > /* We ask for the deleted entries if there is a write lock on the
> > basis that we will eventually need these when we come to write.
> > Getting them now avoids a second file parse. However if we don't
> > ever write it does use more memory. */
>
> But something odd is happening, I am seeing a memory *savings* after applying this patch, unless of course I am reading /proc wrong?

Interesting, I had not considered that. I did put in an optimisation,
some time ago, that makes the without-deleted entries set use the same
memory as the with-deleted set if there are no deleted entries and the
with-deleted set already exists. It's likely that my patch increases
the chances of this occurring. It's also likely you don't have any
deleted entries (items in the deleted state).

Overall, I think a patch along these lines is an improvement.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org