Something I noticed when looking at update performance with char_is_uri_safe

I noticed that some of the biggest hitters in the ltrace are:

[...]
   302==> strchr("/:.-_!~'()@=+$,&*", '-') =
"-_!~'()@=+$,&*"
[...]
  2745==> strchr("/:.-_!~'()@=+$,&*", '_') =
"_!~'()@=+$,&*"
[...]
 14751==> strchr("/:.-_!~'()@=+$,&*", '.') =
".-_!~'()@=+$,&*"

I believe this is caused by this line in libsvn_subr\path.c:715 in
char_is_uri_safe.

  if (strchr ("/:.-_!~'()@=+$,&*", c) != NULL)
    return TRUE;

We could probably hand optimize that strchr with a couple if statements
and save a bundle of time on machines with a slow version of strchr.
 Not a big deal, just that I noticed that strchr was getting a little
bit raped for no apparent reason. :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 26 05:02:26 2002