[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Bringing commit-email.pl update to date (was Re: mailer.py hook-script)

From: Jay McCarthy <jay_at_kenyamountain.com>
Date: 2002-11-25 20:14:45 CET

Patch for commit-email.pl attached.
Also available at
http://www.brunswickrecords.org/~jay/subversion.commit-
email.pl.patch.txt

Log Message:
* hook-scripts/tool/commit-email.pl: Fix arguments passed to 'svnlook'
at the following assignment locations: @svnlooklinks, @dirschanged, and
@difflines.

Note: vim may have screwed up formating against convention.

--- tools/hook-scripts/commit-email.pl 2002-11-19 10:35:37.000000000 -0500
+++ tools/hook-scripts/commit-email.pl.new 2002-11-25 14:00:23.000000000 -0500
@@ -198,15 +198,15 @@
   or die "$0: cannot chdir `$tmp_dir': $!\n";
 
 # Get the author, date, and log from svnlook.
-my @svnlooklines = &read_from_process($svnlook, 'info', $repos, '-r', $rev);
+my @svnlooklines = &read_from_process($svnlook, $repos, 'rev', $rev, 'info');
 my $author = shift @svnlooklines;
 my $date = shift @svnlooklines;
 shift @svnlooklines;
 my @log = map { "$_\n" } @svnlooklines;
 
 # Figure out what directories have changed using svnlook.
-my @dirschanged = &read_from_process($svnlook, 'dirs-changed', $repos,
- '-r', $rev);
+my @dirschanged = &read_from_process($svnlook, $repos,
+ 'rev', $rev, 'dirs-changed');
 
 # Lose the trailing slash in the directory names if one exists, except
 # in the case of '/'.
@@ -224,7 +224,8 @@
   }
 
 # Figure out what files have changed using svnlook.
-@svnlooklines = &read_from_process($svnlook, 'changed', $repos, '-r', $rev);
+@svnlooklines = &read_from_process($svnlook, $repos, 'rev', $rev,
+'changed');
 
 # Parse the changed nodes.
 my @adds;
@@ -259,8 +260,7 @@
 
 # Get the diff from svnlook.
 my @no_diff_on_delete = $no_diff_on_delete ? ('--no-diff-on-delete') : ();
-my @difflines = &read_from_process($svnlook, 'diff', $repos,
- '-r', $rev, @no_diff_on_delete);
+my @difflines = &read_from_process($svnlook, $repos, 'rev', $rev, 'diff', @no_diff_on_delete);
 
 ######################################################################
 # Modified directory name collapsing.

On Monday, November 25, 2002, at 09:33 AM, cmpilato@collab.net wrote:

> Boris Boutillier <Boris.Boutillier@lip6.fr> writes:
>
>> I resolved this issue by suppressing access to the compat_wrap
>> function
>> and i used direcly e_ptr and e_baton as args for svn_repos_dir_delta
>> and
>> this seems to work properly.
>
> Care to submit a patch? You know, share the love with the rest of the
> world?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

--
Jay McCarthy <jay@kenyamountain.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 25 20:16:30 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.